Skip to content

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 12, 2025

No description provided.

@github-actions github-actions bot added the Ruby label Mar 12, 2025
@hvitved hvitved marked this pull request as ready for review March 12, 2025 08:43
Copilot AI review requested due to automatic review settings March 12, 2025 08:43
@hvitved hvitved requested a review from a team as a code owner March 12, 2025 08:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test for SyntheticGlobal functionality in Ruby dataflow summaries.

  • Adds a new test class in summaries.rb to exercise tainted flows from database operations.
  • Updates Summaries.ext.yml to map the newly introduced methods to SyntheticGlobal.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ruby/ql/test/library-tests/dataflow/summaries/summaries.rb Introduces SynthGlobalTest with store and read methods for testing tainted flow handling.
ruby/ql/test/library-tests/dataflow/summaries/Summaries.ext.yml Adds method mappings for saveToDatabase and readFromDatabase using SyntheticGlobal.
Comments suppressed due to low confidence (1)

ruby/ql/test/library-tests/dataflow/summaries/summaries.rb:170

  • The class name 'SynthGlobalTest' is inconsistent with the 'SyntheticGlobal' reference used in the YAML file. Rename it to 'SyntheticGlobalTest'.
class SynthGlobalTest

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@hvitved hvitved merged commit 902b2ff into github:main Mar 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants