Ssa: Refactor the data flow integration module #18857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a result of the commit "SSA: Fix bug in guards for ssa input nodes."
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
github-actions
bot
added
C#
JS
Java
Ruby
Rust
aschackmull
force-pushed
the
ssa/refactor-df-integr
branch
from
5e2c8f2 to
449150e
Compare
hvitved
reviewed
Feb 25, 2025
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM, only one question.
| */ | ||
| class SsaInputNode extends SsaNode { | ||
| override SsaImpl::DataFlowIntegration::SsaInputNode node; | ||
| SsaImpl::Definition getDefinition() { result = node.getDefinition() } |
Contributor
There was a problem hiding this comment.
Could you change the return type to Ssa::Definition and avoid the infix cast below?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aschackmull
force-pushed
the
ssa/refactor-df-integr
branch
from
e2c183d to
28e9644
Compare
hvitved
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review encouraged. I've attempted to make every commit self-contained.
This PR includes a sequence of small changes, including: