Skip to content

Add queries to C# CCR suite #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tamasvajk merged 1 commit into from
Feb 25, 2025
Merged

Add queries to C# CCR suite #18835

tamasvajk merged 1 commit into from
Feb 25, 2025

Conversation

@tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Feb 21, 2025

No description provided.

@github-actions github-actions bot added the C# label Feb 21, 2025
@tamasvajk tamasvajk marked this pull request as ready for review February 24, 2025 10:26
Copilot AI review requested due to automatic review settings February 24, 2025 10:26
@tamasvajk tamasvajk requested a review from a team as a code owner February 24, 2025 10:26
Copilot AI reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

michaelnebel
michaelnebel approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Before merging these queries, we should probably
(1) Run DCA (just get an idea whether the performance is acceptable).
(2) If the performance is acceptable we need to add the CCR queries to CocoFix (mirror the commit as a part of the triage PR).

After this PR has been merged and the triage + adding queries to CocoFix have been merged, it appears that CocoFix needs to be released again: https://github.com/github/codeml-autofix/pull/1626

@tamasvajk tamasvajk merged commit 11d1451 into github:main Feb 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tamasvajk @michaelnebel