Ssa: Refactor shared SSA in preparation for eliminating phi-read definitions #18819

Merged

aschackmull merged 30 commits intogithub:mainfrom

aschackmull:ssa/refactor-phiread3

Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ssa: Refactor shared SSA in preparation for eliminating phi-read definitions #18819

Ssa: Refactor shared SSA in preparation for eliminating phi-read definitions #18819
aschackmull merged 30 commits intogithub:mainfrom
aschackmull:ssa/refactor-phiread3

Commits on Feb 18, 2025

SSA: Elaborate qldoc.

SSA: Remove superfluous conjunct (implied by refRank).

SSA: Remove superfluous boolean.

SSA: Remove superfluous column from liveAtRank.

SSA: Make inReadDominanceFrontier a bit smaller without affecting phi-read creation.

SSA: Factor out phi-read construction in its own predicate.

SSA: Inline predicate

SSA: Copy parts of SsaDefReaches verbatim to new module.

SSA: Copy 3 predicates from the outer scope verbatim into the new Reaches module.

SSA: Ignore phi-reads in the new def-reaches module.

SSA: Replace exported def-reaches predicates (behaviour-preserving).

SSA: Fold getImmediateBasicBlockDominator into loop-invariant predicate.

SSA: Minor perf tweak to reduce tuple duplication.

SSA: Replace uncertainWriteDefinitionInput implementation.

SSA: Restrict phi-read creation to be based on reachable reads.

SSA: Refactor ranking into parameterised module.

SSA: Inline predicate to simplify negation.

SSA: Reimplement use-use.

Java: Simplify SSA for variable capture.

Commits on Feb 19, 2025

SSA: Export simple firstUse and adjacentUseUse predicates.

Java: Use firstUse and adjacentUseUse predicates.

Java: Move SSA data flow test and extend it to cover phi-read input edges.

C#/Ruby/Rust: Fix bug in adjacentReadPairSameVar.

C#: Switch use-use predicates to new implementation.

C#: Clean up unused.

Ruby: Switch use-use predicates to new implementation.

Rust: Switch use-use predicates to new implementation.

SSA: Deprecate unused predicate.

Commits on Feb 20, 2025

Ruby: Accept qltest change.

Ssa: Fix qldoc duplicate word.

Ssa: Refactor shared SSA in preparation for eliminating phi-read definitions #18819aschackmull merged 30 commits intogithub:maingithub/codeql:mainfrom aschackmull:ssa/refactor-phiread3aschackmull/ql:ssa/refactor-phiread3Copy head branch name to clipboard

Commits

Commits on Feb 18, 2025

Commits on Feb 19, 2025

Commits on Feb 20, 2025

Ssa: Refactor shared SSA in preparation for eliminating phi-read definitions #18819
aschackmull merged 30 commits intogithub:mainfrom
aschackmull:ssa/refactor-phiread3