Skip to content

Swift: fix KeyPathExpr assertion #18684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 1 commit into from
Feb 5, 2025
Merged

Swift: fix KeyPathExpr assertion #18684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions swift/extractor/translators/ExprTranslator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,12 +379,7 @@ codeql::KeyPathExpr ExprTranslator::translateKeyPathExpr(const swift::KeyPathExp
entry.components.push_back(emitKeyPathComponent(component));
}
if (auto rootTypeRepr = expr.getExplicitRootType()) {
auto keyPathType = expr.getType()->getAs<swift::BoundGenericClassType>();
CODEQL_EXPECT_OR(return entry, keyPathType, "KeyPathExpr must have BoundGenericClassType");
auto keyPathTypeArgs = keyPathType->getGenericArgs();
CODEQL_EXPECT_OR(return entry, keyPathTypeArgs.size() != 0,
"KeyPathExpr type must have generic args");
entry.root = dispatcher.fetchLabel(rootTypeRepr, keyPathTypeArgs[0]);
entry.root = dispatcher.fetchLabel(rootTypeRepr, expr.getRootType());
}
}
return entry;
Expand Down