All: delete outdated deprecations #18601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C#
JS
C++
Java
Python
Go
Ruby
Swift
DataFlow Library
and removed
JS
labels
erik-krogh
force-pushed
the
del-deps-jan-2025
branch
from
55a9688 to
fcd0f0e
Compare
erik-krogh
force-pushed
the
del-deps-jan-2025
branch
from
dead79a to
90b403b
Compare
…previous naming conflict has been deleted
Contributor
There was a problem hiding this comment.
Copilot reviewed 63 out of 63 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Contributor
|
The old C++ dataflow library can simply not be removed at this point, as there are external repos depending on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simialar to last time: #17349
I recommend the C team look at abe18ad.
That was beyond what I feel comfortable deleting (one thing lead to another...).
There was a bunch of JS deprecations, but I reverted all of them.
Asger committed a lot of deprecations a long time ago, but those only recently made it to main.