Skip to content

Swift: drop indisciminate printing of the env in debug logs #18566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 1 commit into from
Jan 23, 2025
Merged

Swift: drop indisciminate printing of the env in debug logs #18566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions swift/extractor/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,11 @@ static auto argDump(int argc, char** argv) {
static auto envDump(char** envp) {
std::string ret;
for (auto env = envp; *env; ++env) {
ret += *env;
ret += '\n';
if (std::string_view envVar{*env};
envVar.starts_with("CODEQL_") || envVar.starts_with("SEMMLE_")) {
ret += *env;
ret += '\n';
}
}
return ret;
}
Expand All @@ -229,7 +232,7 @@ int main(int argc, char** argv, char** envp) {

const auto configuration = configure(argc, argv);
LOG_INFO("calling extractor with arguments \"{}\"", argDump(argc, argv));
LOG_DEBUG("environment:\n{}\n", envDump(envp));
LOG_DEBUG("CodeQL environment:\n{}\n", envDump(envp));

auto openInterception = codeql::setupFileInterception(configuration);

Expand Down