Skip to content

Dataflow: Another minor join-order fix #18512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 2 commits into from
Jan 17, 2025
Merged

Dataflow: Another minor join-order fix #18512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ffc616
Dataflow: Slight join improvement.
aschackmull Jan 16, 2025
20af2d5
Dataflow: Fix poor join-order
aschackmull Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2154,8 +2154,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
pragma[nomagic]
private predicate storeStepFwd(NodeEx node1, Ap ap1, Content c, NodeEx node2, Ap ap2) {
fwdFlowStore(node1, _, ap1, _, c, _, _, node2, _, _, _) and
ap2 = apCons(c, ap1) and
readStepFwd(_, ap2, c, _, _)
readStepFwd(_, ap2, c, _, ap1)
}

pragma[nomagic]
Expand Down Expand Up @@ -4393,6 +4392,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
Typ getTyp(DataFlowType t) { result = t }

bindingset[c, tail]
pragma[inline_late]
Ap apCons(Content c, Ap tail) { result.isCons(c, tail) }

class ApHeadContent = Content;
Expand Down Expand Up @@ -4462,6 +4462,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
abstract Content getHead();

/** Holds if this is a representation of `head` followed by `tail`. */
pragma[nomagic]
abstract predicate isCons(Content head, AccessPath tail);

/** Gets the front of this access path. */
Expand Down
Loading