Skip to content

Add shared basic block library #18497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paldepind merged 13 commits into from
Jan 24, 2025
Merged

Add shared basic block library #18497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ce5c886
Rust, Ruby: Add basic block test
paldepind Jan 15, 2025
c051eec
Shared: Add shared basic block library
paldepind Jan 15, 2025
8b20b0d
Shared: Add change note for basic block addition
paldepind Jan 16, 2025
4d05b6a
Shared: Address review comments for shared basic block library
paldepind Jan 17, 2025
53b63be
Actions: Implement added predicates in CFG instantiation
paldepind Jan 17, 2025
e382ffc
Shared: Address review comments for basic block library
paldepind Jan 17, 2025
62a459d
Shared: Address basic block review comments
paldepind Jan 20, 2025
f7e9049
Shared: Implement `getScope` in BB module instead of CFG module
paldepind Jan 20, 2025
9a4bf75
Shared: Add more detailed documentation for `immediatelyControls`
paldepind Jan 20, 2025
e5f419c
Shared: Define `getNode` inside cached module
paldepind Jan 22, 2025
9547a5c
Shared: Update basic block documentation and make minor tweaks
paldepind Jan 22, 2025
a537f34
Shared: Tweak basic block documentation
paldepind Jan 23, 2025
e13a7a2
Merge branch 'main' into shared-basic-block-library
paldepind Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions actions/ql/lib/codeql/actions/controlflow/internal/Cfg.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ private module Implementation implements CfgShared::InputSig<Location> {
SuccessorType getAMatchingSuccessorType(Completion c) { result = c.getAMatchingSuccessorType() }

predicate isAbnormalExitType(SuccessorType t) { none() }

int idOfAstNode(AstNode node) { none() }
Copy link
Contributor Author

@paldepind paldepind Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that getJoinBlockPredecessor isn't implemented in the Actions basic block library, so this instantiation is actually fine. And we could move Actions to the shared BB library in a future PR.


int idOfCfgScope(CfgScope scope) { none() }
}

module CfgImpl = CfgShared::Make<Location, Implementation>;
Expand Down
Loading
Loading