Skip to content

Dataflow: Remove some dead code. #18423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschackmull merged 1 commit into from
Jan 7, 2025
Merged

Dataflow: Remove some dead code. #18423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,12 +894,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
pragma[nomagic]
predicate revFlow(NodeEx node) { revFlow(node, _) }

pragma[nomagic]
predicate revFlowAp(NodeEx node, Ap ap) {
revFlow(node) and
exists(ap)
}

bindingset[node, state]
predicate revFlow(NodeEx node, FlowState state, Ap ap) {
revFlow(node, _) and
Expand Down Expand Up @@ -1278,8 +1272,6 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {

predicate revFlow(NodeEx node);

predicate revFlowAp(NodeEx node, Ap ap);

bindingset[node, state]
predicate revFlow(NodeEx node, FlowState state, Ap ap);

Expand Down Expand Up @@ -2456,16 +2448,11 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
)
}

additional predicate revFlow(NodeEx node, FlowState state) { revFlow(node, state, _, _, _) }

predicate revFlow(NodeEx node, FlowState state, Ap ap) { revFlow(node, state, _, _, ap) }

pragma[nomagic]
predicate revFlow(NodeEx node) { revFlow(node, _, _, _, _) }

pragma[nomagic]
predicate revFlowAp(NodeEx node, Ap ap) { revFlow(node, _, _, _, ap) }

private predicate fwdConsCand(Content c, Ap ap) { storeStepFwd(_, ap, c, _, _) }

private predicate revConsCand(Content c, Ap ap) {
Expand Down Expand Up @@ -2620,7 +2607,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
*/
private class FlowCheckNode extends NodeEx {
FlowCheckNode() {
revFlow(this, _, _) and
revFlow(this) and
(
flowCheckNode(this) or
Config::neverSkip(this.asNode())
Expand Down
Loading