Upgrade bazel to 8.0.0. #18257
Merged
Upgrade bazel to 8.0.0. #18257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C#
Python
Go
Rust
criemen
force-pushed
the
criemen/bazel-8-00
branch
from
fb91556 to
ce04ea6
Compare
Previously, we were using 8.0.0rc1. In particular, this upgrade means we need to explicitly import more rules, as they've been moved out of the core bazel repo.
criemen
force-pushed
the
criemen/bazel-8-00
branch
from
ce04ea6 to
53ca508
Compare
redsun82
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using 8.0.0rc1.
In particular, this upgrade means we need to explicitly import more rules, as they've been moved out of the core bazel repo.
I did all the work of importing
rules_shelleverywhere, and then discovered thatrules_gostill requires the autoload.I kept the changes, as I believe they go in the right direction, and once bazel-contrib/rules_go#4193 has been fixed, we can switch over for good.