chore(actions): bump to artifacts@v4 #17963
Conversation
`ruby-dataset-measure.yml` is not updated yet as it requires aid from the language team. We can presumably disable the workflow during the brownout periods, but a fix will have to be present before the full deprecation happens
esbena
force-pushed
the
esbena/actions/artifact-v4
branch
from
19845a5 to
2f0fa5c
Compare
esbena
force-pushed
the
esbena/actions/artifact-v4
branch
from
2f0fa5c to
3b814c5
Compare
|
Upon qhelp changes: https://github.com/github/codeql/actions/runs/11797379443 fails because it runs from |
esbena
force-pushed
the
esbena/actions/artifact-v4
branch
from
3b814c5 to
2f50d25
Compare
criemen
left a comment
criemen
left a comment
There was a problem hiding this comment.
LGTM - one nit you can choose to address or not.
| run: gh run download "${WORKFLOW_RUN_ID}" --repo "${GITHUB_REPOSITORY}" --name "comment" | ||
| - name: Download artifacts | ||
| run: | | ||
| gh run download "${WORKFLOW_RUN_ID}" --repo "${GITHUB_REPOSITORY}" --name "comment-pr-number" |
There was a problem hiding this comment.
Nit: Per https://cli.github.com/manual/gh_run_download, you can specify multiple names in one go.
But, tbh, I'd really prefer to use something ala
- uses: actions/download-artifact@v4
with:
name: comment
github-token: ${{ github.token }}
run-id: ${{ github.event.workflow_run.id }}
pattern: "comment-*"
(this is untested and freestyled) over bash scripts that invoke the cli.
Potentially you also want to use merge-multiple: true.
There was a problem hiding this comment.
neat. Thanks.
I'll try not to rock the boat at all here though.
https://github.com/actions/upload-artifact and https://github.com/actions/download-artifact are deprecating
v3soon, and this PR bumps naively tov4.From skimming,From running, several workflows seem to be hit by the unique name restriction mentioned in https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. This needs investigation..github/workflows/qhelp-pr-preview.yml