Rust: Expose counts of data flow inconsistencies #17908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Consistency.qll, so it's possibly to access inconsistency data as a whole.
…a flow inconsistency counts.
Contributor
Author
|
DCA LGTM (it doesn't show the new data anywhere yet; but the new query is run and doesn't cause any problems) |
paldepind
approved these changes
Nov 6, 2024
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
LGTM!
About the duplication: It doesn't seem so bad to me and FWIW I can't think of any way of phrasing it that would be simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust: expose counts of data flow inconsistencies in
rust/summary/summary-statisticsand new diagnostic queryrust/diagnostics/data-flow-consistency-counts. This (the former, at the moment) will allow us to display data flow inconsistencies in DCA runs.Shared: there's a change to the shared library
DataFlowImplConsistency.qllin the addition of a predicategetInconsistencyCounts. It's not super clean as it duplicates some information from the existing query predicates - but on the other hand it prevents that duplication from having to go any further (e.g. into language specific diagnostic queries). There might be a nicer way to do this, perhaps involving an abstractclass DataFlowInconsistencythat collects all results in one place ... but that would inevitably end up changing how results are listed in.expectedfiles (probably for the worse). I'm open to better ideas.