JS: Add a missing class to needsDefNode

asgerf · asgerf · commit bde7253de076 · 2025-11-27T13:25:57.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/ApiGraphs.qll b/javascript/ql/lib/semmle/javascript/ApiGraphs.qll
@@ -1534,6 +1534,7 @@ module API {
           succ = MkDef(rhs)
           or
           exists(DataFlow::ClassNode cls |
+            needsDefNode(cls) and
             cls.getAnInstanceReference().flowsTo(rhs) and
             succ = MkClassInstance(cls)
           )

Original file line number	Diff line number	Diff line change
`@@ -1534,6 +1534,7 @@ module API {`
`1534`	`1534`	`succ = MkDef(rhs)`
`1535`	`1535`	`or`
`1536`	`1536`	`exists(DataFlow::ClassNode cls \|`
	`1537`	`+ needsDefNode(cls) and`
`1537`	`1538`	`cls.getAnInstanceReference().flowsTo(rhs) and`
`1538`	`1539`	`succ = MkClassInstance(cls)`
`1539`	`1540`	`)`