JS: Remove accidental SourceNode restriction

asgerf · asgerf · commit dc69986ee22c · 2025-11-27T11:58:18.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/ApiGraphs.qll b/javascript/ql/lib/semmle/javascript/ApiGraphs.qll
@@ -1672,7 +1672,7 @@ module API {
 
       /** Holds if def-node tracking starting at `nd` can reach a node in the overlay. */
       pragma[nomagic]
-      private predicate shouldBacktrackIntoOverlay(DataFlow::SourceNode nd) {
+      private predicate shouldBacktrackIntoOverlay(DataFlow::Node nd) {
         exists(DataFlow::Node overlayNode |
           stepOutOfOverlay(overlayNode, Stage1Local::trackDefNodeAnyState(nd))
         )

Original file line number	Diff line number	Diff line change
`@@ -1672,7 +1672,7 @@ module API {`
`1672`	`1672`
`1673`	`1673`	/** Holds if def-node tracking starting at `nd` can reach a node in the overlay. */
`1674`	`1674`	`pragma[nomagic]`
`1675`		`- private predicate shouldBacktrackIntoOverlay(DataFlow::SourceNode nd) {`
	`1675`	`+ private predicate shouldBacktrackIntoOverlay(DataFlow::Node nd) {`
`1676`	`1676`	`exists(DataFlow::Node overlayNode \|`
`1677`	`1677`	`stepOutOfOverlay(overlayNode, Stage1Local::trackDefNodeAnyState(nd))`
`1678`	`1678`	`)`