add dialog-toggle-events polyfill#77
Merged
keithamus merged 2 commits intogithub:mainfrom Feb 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR integrates the dialog-toggle-events polyfill into the library so that downstream consumers, such as Primer, can benefit from the polyfill without needing to include it separately.
- Adds an import statement for the polyfill from the external package.
- Exports the polyfill as part of the polyfills object.
Reviewed Changes
| File | Description |
|---|---|
| src/index.ts | Added import and export for dialog-toggle-events polyfill |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
arelia
previously approved these changes
Feb 25, 2025
keithamus
force-pushed
the
add-dialog-toggle-events-polyfill
branch
from
6af6c50 to
eb0edfa
Compare
keithamus
force-pushed
the
add-dialog-toggle-events-polyfill
branch
from
eb0edfa to
cfd4904
Compare
arelia
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In primer/view_components#3332 we're pulling in a dialog-toggle-events-polyfill. Ideally, however, all polyfills should be part of this library.
This PR introduces the same dialog-toggle-events-polyfill to this library, so that other downstream libraries like Primer may use it.