Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR imports the invokers polyfill into the project's suite of polyfills to eventually remove custom handling of invokers in Primer.
- Adds an import statement for the invokers polyfill.
- Includes the polyfill in the exported polyfills object.
Reviewed Changes
| File | Description |
|---|---|
| src/index.ts | Imported the invokers polyfill and added it to the polyfills export object |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/index.ts:6
- [nitpick] Consider renaming the alias 'commandAndCommandFor' to a more descriptive name, such as 'invokersPolyfill', to improve clarity.
import * as commandAndCommandFor from 'invokers-polyfill'
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
keithamus
force-pushed
the
add-invokers-polyfill
branch
2 times, most recently
from
de6123b to
499b372
Compare
arelia
previously approved these changes
Feb 25, 2025
keithamus
force-pushed
the
add-invokers-polyfill
branch
from
499b372 to
0461cc6
Compare
dgreif
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of primer/view_components#3331 I'd like to import the invokers polyfill into our suite of polyfills, to allow us to slowly remove code in Primer which handles this in a custom way.