Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds the popover polyfill as a dependency to support functionality like tooltips and menus in Primer libraries.
- Added a polyfill import in src/index.ts
- Updated the polyfills object to expose the popover polyfill
Reviewed Changes
| File | Description |
|---|---|
| src/index.ts | Imported the popover polyfill and added it to exports |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
arelia
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Primer ViewComponent & Primer React import & depend on the popover polyfill in order to offer functionality like tooltips and menus. This isn't properly reflected in our compatibility table, nor is it properly enumerated as a dependency here.
I'd like us to steer Primer toward using this browser-support library instead of individual polyfills, so better align with the goals of the monolith. So this PR introduces the popover polyfill as a dependency of this library, so that we can migrate the Primer libraries to using this library.