Skip to content

Conversation

@ljharb
Copy link

@ljharb ljharb commented Jan 24, 2026

Updates

  • Affected products

Comments
In v1.x, the @ is correctly identified as an auth separator, but when auth is empty, the toString() method has no way to know there was an @ in the original URL. The fix adds a check: if there's no host but there is a pathname (and it's a special protocol), re-add the @ to preserve the original invalid URL structure.

In v0.x, the regex-based approach doesn't cleanly separate empty auth - it ends up treating @ as part of the hostname, which accidentally preserves it in the output.

In v0.x, the final href is: http://@/127.0.0.1 The @ is preserved, which is the correct/safe behavior. This matches the original input.

In contrast, v1.x (vulnerable) outputs: http:///127.0.0.1. The @ is lost, which is the security issue - if code checks hostname (empty) to allow the request, then uses href to make the request, the /127.0.0.1 in the pathname could be misinterpreted by some HTTP clients as a host, leading to SSRF.

Copilot AI review requested due to automatic review settings January 24, 2026 00:14
@github-actions github-actions bot changed the base branch from main to ljharb/advisory-improvement-6700 January 24, 2026 00:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a security advisory for the url-parse package to accurately reflect which versions are affected by CVE-2022-0639. The vulnerability only affects v1.x of the package, not v0.x, as v0.x uses a regex-based approach that correctly preserves the '@' character in malformed URLs.

Changes:

  • Updated the introduced version from "0" to "1.0.0" to correctly indicate that only v1.x is vulnerable
  • Updated the modified timestamp to reflect the change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants