feat(github-app): allow several github apps to be used#5038
Open
thomasnemer wants to merge 3 commits intogithub-aws-runners:mainfrom
Open
feat(github-app): allow several github apps to be used#5038thomasnemer wants to merge 3 commits intogithub-aws-runners:mainfrom
thomasnemer wants to merge 3 commits intogithub-aws-runners:mainfrom
Conversation
Contributor
|
@thomasnemer can you fix the conflicts? |
Contributor
Author
|
For sure. I'll rebase early next week. |
19c2869 to
9d0d0dc
Compare
Contributor
Author
|
@edersonbrilhante done :) |
Member
|
@thomasnemer can you check the failing pipepline? |
bb58cca to
28ea8a2
Compare
Contributor
Author
|
@npalm done :) (+ rebased and resolved a conflict on scale-up.ts) |
28ea8a2 to
03f5370
Compare
Contributor
Author
|
@npalm : How confident are we with merging this PR for it to be part of the next release? Not pushing forward at all, just planning for internal maintenance of our non-production environment :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additional_github_appsvariable (optional, no breaking changes) accepts a list of extra apps withid,key_base64, and optionallyinstallation_id(all support direct values or SSM references)installation_idwhen provided, falling back to an API lookup only when neededContext
At enterprise scale with many runner configurations, all Lambda functions (scale-up, scale-down, pool, job-retry) share a single GitHub App's rate limit bucket (15,000 req/hour on GitHub Enterprise Cloud). This ceiling cannot be raised per-app — the only way to scale is to spread load across multiple apps. This change makes the effective limit
N × 15,000req/hour, without introducing breaking changes.Closes #5037