fixup for CI#1
Merged
Merged
Conversation
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
3 times, most recently
from
80dee97 to
54ac97d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version from 0.0.5 to v0.0.6 across the codebase and updates the Linux kernel version from 6.12.47 to 6.12.49. The changes also include memory optimization and CI workflow improvements.
- Version bump from 0.0.5 to v0.0.6 across all Cargo.toml files and Docker image references
- Linux kernel update from 6.12.47 to 6.12.49 with corresponding clang version updates
- Memory configuration optimization (reduced hugepages from 32 to 16, VM memory from 256MB to 128MB)
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| n-vm/src/lib.rs | Updates Docker image version, reduces VM memory allocation and hugepages |
| n-vm/Cargo.toml | Version bump to 0.0.6 |
| n-vm-macros/Cargo.toml | Version bump to 0.0.6 |
| n-it/Cargo.toml | Version bump to 0.0.6 |
| linux/kernel.config | Updates kernel version to 6.12.49 and clang to 21.1.1 |
| default.nix | Updates Linux kernel version and SHA256 hash |
| README.md | Updates Docker image reference and improves text formatting |
| .github/workflows/basic.yml | Streamlines CI workflow and updates Docker image version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
from
54ac97d to
3d77200
Compare
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
5 times, most recently
from
85fbc3b to
92a0a11
Compare
This makes development somewhat easier. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Signed-off-by: Daniel Noland <daniel@githedgehog.com>
We also reduce the number of expressly allocated hugepages in each vm. This is more in line with our actual workload. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
from
92a0a11 to
73fa77f
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
from
73fa77f to
96966bb
Compare
This part of the code needs enough rework that I'm not going to bother explaining all of the temporary hacks needed to make this more reliable. Instead, I plan to write a proper design doc and rework this as I re-add support for dpdk in dataplane. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
This introduces CI managed push of the container images. It is very primitive for the moment. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
daniel-noland
force-pushed
the
pr/daniel-noland/v0.0.6
branch
from
96966bb to
9cdd8d4
Compare
sergeymatov
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix CI and other minor fixes