Skip to content

much cleaner

35de66c
Select commit
Loading
Failed to load commit list.
Closed

scratch #1162

much cleaner
35de66c
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Jan 2, 2026 in 1s

Check failed

There are 94 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 2429853 build(nix): introduce nix build system Valid sign-off found
🟢 ee81a9d build(nix): intro addToEnv helper Valid sign-off found
🟢 3167008 build(nix): introduce stdenv-llvm Valid sign-off found
🟢 086d3c3 build(nix): add llvm's bintools and lld to stdenv Valid sign-off found
🟢 522e265 build(nix): disable checks in stdenv Valid sign-off found
🟢 18dc2c5 build(nix): intro stdenv-llvm-with-flags Valid sign-off found
🟢 47e5093 build(nix): intro dataplane-dep helper function Valid sign-off found
🟢 525851e build(nix): null ethtool and iproute2 Valid sign-off found
🟢 7f263fc build(nix): null heavy doc tools Valid sign-off found
🟢 266b2a4 build(nix): null systemd + helpers Valid sign-off found
🟢 c4ebd6a build(nix): introduce overlay for libmd Valid sign-off found
🟢 dadde46 build(nix): introduce overlay for libbsd Valid sign-off found
🟢 eb0b56c build(nix): introduce overlay for libnl Valid sign-off found
🟢 c5be4af build(nix): introduce overlay for numactl Valid sign-off found
🟢 ce7b2a9 build(nix): introduce overlay for rdma-core Valid sign-off found
🟢 488112c build(nix): introduce npins package management Valid sign-off found
🟢 ac0c9da build(nix): pin our version of rdma-core Valid sign-off found
🟢 60d760b build(nix): import pinned sources into default.nix Valid sign-off found
🟢 129ba17 build(nix): import nixpkgs from npins source Valid sign-off found
🟢 e63103f build(nix): introduce default overlay Valid sign-off found
🟢 18be22b build(nix): pipe pinned sources to dataplane overl... Valid sign-off found
🟢 15021b8 build(nix): use pinned rdma-core Valid sign-off found
🟢 3c2507a build(nix): pin DPDK to version 25.11 Valid sign-off found
🟢 09575cd build(nix): introduce dpdk package Valid sign-off found
🟢 28f6f1c build(nix): replace dpdk build in dataplane overla... Valid sign-off found
🟢 8439e02 build(nix): expose pkgs in default.nix Valid sign-off found
🟢 f9f55b3 build(nix): add dataplane overlay to default.nix Valid sign-off found
🟢 1850879 build(nix): pipe env into overlays Valid sign-off found
🟢 c8d29b6 build(nix): frame common profile Valid sign-off found
🟢 733d9a1 build(nix): frame debug profile Valid sign-off found
🟢 c8cd3bd build(nix): frame optimize profile Valid sign-off found
🟢 c14d487 build(nix): frame secure profile Valid sign-off found
🟢 73c18e3 build(nix): add notes about cf-protection, cfi, an... Valid sign-off found
🟢 0fa5f56 build(nix): intro combine-profiles Valid sign-off found
🟢 fd26b1a build(nix): define debug environment Valid sign-off found
🟢 ce71a57 build(nix): define release environment Valid sign-off found
🟢 3f046c4 build(nix): pipe environments into build Valid sign-off found
🟢 b795b36 build(nix): introduce fat-lto-objects flag (for th... Valid sign-off found
🟢 941ca3c style(nix): sort outputs in dpdk build Valid sign-off found
🟢 a9f5037 refactor(nix): move profiles.nix to nix folder Valid sign-off found
🟢 7fe5a94 build(nix): introduce x86_64 march flags Valid sign-off found
🟢 51c93bb build(nix): introduce aarch64 march flags Valid sign-off found
🟢 494278a build(nix): introduce build profiles Valid sign-off found
🟢 1d8133c build(nix): introduce cross compile / profile infr... Valid sign-off found
🟢 4eb38d7 build(nix): compile dpdk_wrapper.a with nix Valid sign-off found
🟢 6de393c build(nix): make overlay user selectable Valid sign-off found
🟢 ec93642 build(nix): add address sanitize profile Valid sign-off found
🟢 7ba060a build(nix): add leak sanitize profile Valid sign-off found
🟢 a7e4bfa build(nix): add cfi sanitize profile Valid sign-off found
🟢 e80a3b8 build(nix): add safe-stack sanitize profile Valid sign-off found
🟢 c06df86 build(nix): add instrumentation profiles Valid sign-off found
🟢 296584b build(nix): pipe sanitizer and instrumentation int... Valid sign-off found
🔴 409bea5 build(nix): add thread sanitize profile Sign-off not found
🔴 216e62e build(nix): forward cflags back to linker in optim... Sign-off not found
🔴 eba10ef fix(nix): missing acc // for one offs Sign-off not found
🔴 9d4098c build(nix): make most sanitizers work Sign-off not found
🔴 61e4078 build(nix): add copyright headers Sign-off not found
🔴 da03e9f wip Sign-off not found
🔴 a969708 wip Sign-off not found
🔴 25058ac wip Sign-off not found
🔴 4353592 wip Sign-off not found
🔴 f07f3a0 wip Sign-off not found
🔴 a5f2ae2 wip Sign-off not found
🔴 a0d64a4 wip Sign-off not found
🔴 e4d166a pkgsBuildHost Sign-off not found
🔴 965cb3c wip Sign-off not found
🔴 c2d91c1 pkgsBuildHost Sign-off not found
🔴 c5264c7 wip (moderate rework) Sign-off not found
🔴 1378eff wip Sign-off not found
🔴 221e671 hack Sign-off not found
🔴 576a97b fix rust build Sign-off not found
🔴 8d7fc0c dataplane now builds, but need to undo lots of hac... Sign-off not found
🔴 c852dae fix cross compile errooooor Sign-off not found
🔴 1585a8b hacky cross compile working Sign-off not found
🔴 6bcb117 less hacky (seems to work with mcpu) Sign-off not found
🔴 3d5390d less hacky still Sign-off not found
🔴 4b68ec9 mostly building again with the old method Sign-off not found
🔴 b8c1e08 mostly workin (including musl) Sign-off not found
🔴 b18a683 de-src dpdk Sign-off not found
🟢 1d8bf26 build: re-introduce default-members into workspace Valid sign-off found
🟢 da61c96 build(hardware): remove unused dependency on sysro... Valid sign-off found
🟢 b1e2b30 build(sysfs): remove unused dependency on sysroot Valid sign-off found
🟢 12031a3 refactor(dpdk-sysroot-helper): drop unused get_pro... Valid sign-off found
🟢 de050ee refactor(dpdk-sysroot-helper): drop unused get_com... Valid sign-off found
🟢 c9c9d12 feat(dpdk-sysroot-helper): intro use_sysroot funct... Valid sign-off found
🟢 9821a30 refactor(cli): invoke use_sysroot to de-duplicate ... Valid sign-off found
🟢 5097977 refactor(init): invoke use_sysroot to de-duplicate... Valid sign-off found
🟢 b5e5835 refactor(dpdk): invoke use_sysroot to de-duplicate... Valid sign-off found
🟢 053341d refactor(dataplane): invoke use_sysroot to de-dupl... Valid sign-off found
🟢 4b79b49 build(cli): make sysroot optional Valid sign-off found
🟢 e7f16a6 build(init): make sysroot optional Valid sign-off found
🟢 1d9a183 build: remove init from default-members list Valid sign-off found
🟢 8700e2a build: remove dpdk and friends from default-member... Valid sign-off found
🟢 1c276f2 build: remove hardware from default-members list Valid sign-off found
🟢 47087ad build(dataplane): make sysroot and dpdk optional f... Valid sign-off found
🟢 1cffe66 build: drop most of config.toml Valid sign-off found
🔴 73c3cb9 doc(net): remove pointless cfg(doc) trick Sign-off not found
🔴 875f019 build: make nix/socket dependency explicit Sign-off not found
🔴 5fcdca9 great build build refactor Sign-off not found
🔴 6bd3f51 wip Sign-off not found
🔴 d25186c christmas time Sign-off not found
🔴 f1f0b5c going to try oxa's overlay Sign-off not found
🔴 dd72889 clang linker issue for cross compile Sign-off not found
🔴 bd91287 working cross again Sign-off not found
🔴 1f00773 fixup result exclude Sign-off not found
🔴 352e096 many things mostly working Sign-off not found
🔴 4df9264 more stuff working Sign-off not found
🔴 b630fab wip Sign-off not found
🔴 ec068d6 wip Sign-off not found
🔴 343dc64 hack Sign-off not found
🔴 35aa809 hack2 Sign-off not found
🔴 7183e68 big hack Sign-off not found
🔴 c7a5ff6 Update dev.yml Sign-off not found
🔴 7977554 Update dev.yml Sign-off not found
🔴 d8e9d88 wip Sign-off not found
🔴 344d154 fix Sign-off not found
🔴 4c009ec frustration Sign-off not found
🔴 e3393dd better yet Sign-off not found
🔴 2839242 cachix test 0 Sign-off not found
🔴 108d99c wth Sign-off not found
🔴 c9db541 unclear Sign-off not found
🔴 862de7b confusing Sign-off not found
🔴 ed17722 very confusing Sign-off not found
🔴 f1eabd0 extra confuse Sign-off not found
🔴 caf8cbf less confusing Sign-off not found
🔴 c0292ed substitute Sign-off not found
🔴 47b0cf9 wip Sign-off not found
🔴 29afe75 wiip Sign-off not found
🔴 4ccec1b cleanup 0 Sign-off not found
🔴 e920638 more wip Sign-off not found
🔴 a413120 scratch Sign-off not found
🔴 51dcd2b wip again Sign-off not found
🔴 001e574 wip Sign-off not found
🔴 dc0a00d wip again Sign-off not found
🔴 ce2add3 wip Sign-off not found
🔴 d38c72d wip Sign-off not found
🔴 74a3186 wip Sign-off not found
🔴 5c9f188 switch sysroot and devroot Sign-off not found
🔴 cbb92e6 revert Sign-off not found
🔴 85d9557 revert me as well Sign-off not found
🔴 2f39d6f broken again Sign-off not found
🔴 73444c0 still not quite clippy working Sign-off not found
🔴 6f8bac5 fix nonsense Sign-off not found
🔴 755c79e SYSROOT->DATAPLANE_SYSROOT Sign-off not found
🔴 9874237 leak san working? Sign-off not found
🔴 4d66248 hacky, but thread sanitizer compiles Sign-off not found
🔴 89b8caf a little cleaner Sign-off not found
🔴 e697f90 wip Sign-off not found
🔴 68b0602 wip Sign-off not found
🔴 d4b44e9 some cleanup but way too much jank Sign-off not found
🔴 6901439 less messy but some attrition Sign-off not found
🔴 c21898d fenix cleanup Sign-off not found
🔴 4682469 more cleanup Sign-off not found
🔴 3af2498 wip Sign-off not found
🔴 8447f5a wip Sign-off not found
🔴 38ab338 more fancy Sign-off not found
🔴 414671e tests sorta workin Sign-off not found
🔴 44dc024 clippy? Sign-off not found
🔴 238eae9 separate build deps mostly working Sign-off not found
🔴 0feb81d container time Sign-off not found
🔴 f0d1456 cleanup happening Sign-off not found
🔴 d32dbc9 more cleanup Sign-off not found
🔴 35de66c much cleaner Sign-off not found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~163 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin refactor-flags2