Skip to content

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Jan 15, 2026

Currently, there is an extra comma in the exercise-sources JSON, which causes an error in JSON parsing if we copy it over.

image image image

Fixed the bug to improve developer experience, so that they can copy it directly without any errrors.

@github-actions
Copy link

Hi @jovnc, thank you for your contribution! 🎉

This PR comes from your fork jovnc/exercises on branch fix/contribution-message.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "jovnc",
        "repository": "exercises",
        "branch": "fix/contribution-message",
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

  • (For exercises and hands-ons) I have verified that the downloading behavior works
  • (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

Copy link
Contributor

@SAN-MUYUN SAN-MUYUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this issue, LGTM!

Copy link
Contributor

@jiaxinnns jiaxinnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested it out and LGTM!

@jovnc jovnc merged commit 4f2ffbb into git-mastery:main Jan 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants