Fix arch publish release AMD64 URL #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovnc
added
bug
woojiahao
approved these changes
Jan 12, 2026
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Great catch, thank you for resolving this
woojiahao
added
bump:minor
Member
|
Changing release type to minor since we would want our Arch users to update. We should figure out a good way to reason about versioning and what changes are treated as patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes git-mastery/git-mastery#57
Problem
The arch-publish GitHub Action publishes an incorrect AMD64 release download URL, which breaks installation on Arch (e.g., via yay gitmastery-bin). Based on workflow logs, releases starting from ≥7.1.3 are affected.
It is fetching from the following URL:
https://github.com/git-mastery/app/releases/download/main/gitmastery-7.1.4-linux-amd64
Instead, it should be fetching from this URL:
https://github.com/git-mastery/app/releases/download/7.1.4/gitmastery-7.1.4-linux-amd64
Root Cause
arch-publish is triggered via workflow_run. In this context, ${{ github.ref_name }} resolves to the branch name that triggered the upstream workflow (e.g., main) rather than the release tag.
This causes the action to construct download URLs using main instead of the version tag, even though the actual package version is correctly determined (e.g., logs show pkgver="v7.1.4").
Fix
Replace ${{ github.ref_name }} with needs.prepare.outputs.ref_name (the tag value)