Preserve symlinks when writing config files in install-hooks
#403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
`write_atomic()` breaks symlinks when updating configuration files. This causes `install-hooks` to break setups where config/settings files are symlinked (e.g. via a dotfiles repo). This updates the logic to resolve symlinks (if present) before writing.
venables
force-pushed
the
venables/fix-claude-code-symlink
branch
from
bbac19c to
7a2e6eb
Compare
venables
changed the title
install-hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_atomic()breaks symlinks when updating configuration files. This causesinstall-hooksto break setups where config/settings files are symlinked (e.g. via a dotfiles repo).This updates the logic to resolve symlinks (if present) before writing.