-
Notifications
You must be signed in to change notification settings - Fork 57
add legend style option : size, front, color #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @nforquet |
ghtmtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks for this contribution! From the screenshot it seemed that you created already existing properties and not that you added the legend customization!
Not sure what is happening but when opening the UI font, size and color widget are different from all the others. Can you please normalize it?
DataPlotly/core/plot_settings.py
Outdated
| PROPERTY_FONT_LEGEND_SIZE = 27 | ||
| PROPERTY_FONT_LEGEND_FAMILY = 28 | ||
| PROPERTY_FONT_LEGEND_COLOR = 29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you continue the numeration? 30, 31, 32
|
Hi @ghtmtt , Thank you for your review ! |
|
@soaubier there are some conflicts, can you fix them? So I'll merge this PR! Thanks! |
8262be3 to
8cb6faa
Compare
|
Hi @ghtmtt , thanks for the quick reply!
They still keep support for title and legend. |
|
thanks @soaubier! LGTM, I'm going to merge the pull request and release a new version ASAP |

Add style option for all plot type. With the implementation of :
Funded by INRAE - Reversaal