Implement needed modifications for issue #12600, more flexible copy-on-select and middle-click-action#12604
Open
mohshami wants to merge 20 commits into
Open
Implement needed modifications for issue #12600, more flexible copy-on-select and middle-click-action#12604mohshami wants to merge 20 commits into
mohshami wants to merge 20 commits into
Conversation
For middle-click-action * Kept the option "primary-paste" instead of "paste-primary" to keep backwards compatibility * Added the option "clipboard-paste" For copy-on-select * Added the both, none and primary options Updated config documentation
Contributor
|
Hi @mohshami, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
Member
|
!vouch |
Merged
ghostty-vouch Bot
added a commit
that referenced
this pull request
May 6, 2026
Triggered by [comment](#12604 (comment)) from @jcollie. Vouch: @mohshami Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jcollie
requested changes
May 18, 2026
xi-guan
pushed a commit
to xi-guan/cmux-ghostty
that referenced
this pull request
May 18, 2026
Triggered by [comment](ghostty-org#12604 (comment)) from @jcollie. Vouch: @mohshami Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
00-kat
requested changes
May 18, 2026
Contributor
00-kat
left a comment
00-kat
left a comment
There was a problem hiding this comment.
Thanks a lot! These are a couple comments I had on my mind when you first opened this PR, but I wanted to hold off until someone else asked you to use the backward compat mechanism instead (I don't know much about it, so I didn't know how to phrase that request then).
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Contributor
|
JSYK GitHub has a button to batch-add suggestions. |
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
Co-authored-by: kat <65649991+00-kat@users.noreply.github.com>
jcollie
approved these changes
May 18, 2026
00-kat
approved these changes
May 18, 2026
Contributor
|
(Disabled auto-merge since it still needs a review from someone in ghostty-org/terminal, so it wouldn't auto-merge until that happens.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For middle-click-action
For copy-on-select
Updated config documentation
Note: No AI was used, Even though I don't know Zig, I looked at the code and the modifications seemed easy enough
Closes #12600