i18n: translation support for command palete#11641
i18n: translation support for command palete#11641EriksRemess wants to merge 4 commits intoghostty-org:mainfrom
Conversation
mitchellh
left a comment
There was a problem hiding this comment.
I definitely want more reviewers, but this in general makes sense. I made one note.
|
It would be nice if Latvian translation updates were done in a separate future PR, since that requires a review from a completely different set of people as the rest of the code and is orthogonal to this PR. |
|
Also, I'm not sure how it's done but I believe you need to update all the other translation files to have the untranslated strings placed in them; other PRs that added translations (e.g. #9976) have done so. |
|
Ok, I'll remove Latvian translation for now. Should I also remove |
|
Definitely keep the |
It looks like ghostty/src/build/GhosttyI18n.zig Lines 185 to 190 in c2e9de2 If it changed every single translation file to add untranslated strings, you should probably |
|
I guess, test should be retried https://github.com/ghostty-org/ghostty/actions/runs/23306874737/job/67784178019?pr=11641 |
|
Thanks!
Done. |
Most obvious next step in translating Ghostty is the command palette.
Added support for i18n.N_ (https://docs.gtk.org/glib/i18n.html#macros).
Made a Latvian translation for the command palette to test. Codex did bulk of the translations but I verified them.