Skip to content

Conversation

@mfjurbala
Copy link
Member

@mfjurbala mfjurbala commented Apr 26, 2025

During install, the file /var/db/zoneinfo is not created. This change now creates the file so the user's local time is shown on the login and lock screens.

Summary by Sourcery

Bug Fixes:

  • Save the selected timezone to /var/db/zoneinfo during setup.

During install, the file /var/db/zoneinfo is not created. This change now creates the file so the user's local time is shown on the login and lock screens.
@mfjurbala mfjurbala requested review from a team as code owners April 26, 2025 23:55
@sourcery-ai
Copy link

sourcery-ai bot commented Apr 26, 2025

Reviewer's Guide by Sourcery

This pull request addresses an issue where the timezone file /var/db/zoneinfo was not created during installation, leading to incorrect time display on the login and lock screens. The fix involves adding a command to create this file and write the selected timezone name into it within the set_timezone function.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Create the timezone file during installation
  • Add command to write the timezone name to /var/db/zoneinfo using tee.
backend/functions-localize.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mfjurbala - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider ensuring the parent directory exists before writing to ${FSMNT}/var/db/zoneinfo.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

{
TZONE="$1"
cp ${FSMNT}/usr/share/zoneinfo/${TZONE} ${FSMNT}/etc/localtime
echo ${TZONE} | tee ${FSMNT}/var/db/zoneinfo > /dev/null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Quote shell variables to avoid word splitting issues.

Wrap variable references in double quotes (e.g. "${TZONE}" and "${FSMNT}/var/db/zoneinfo") to ensure the script handles values with spaces or special characters correctly.

Suggested implementation:

  cp "${FSMNT}/usr/share/zoneinfo/${TZONE}" "${FSMNT}/etc/localtime"

  echo "${TZONE}" | tee "${FSMNT}/var/db/zoneinfo" > /dev/null

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Development Tracker May 11, 2025
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 8bc5f40 into ghostbsd:master May 12, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Tracker May 12, 2025
@ericbsd ericbsd assigned ericbsd and mfjurbala and unassigned ericbsd Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants