Skip to content

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 14, 2025

The gfx-glogo.lua file was outdated. I brought it up to date.

Summary by Sourcery

Update gfx-glogo.lua to modernize the logo configuration by restructuring the ASCII graphic section, adding a framebuffer logo subsection, and correcting logo positioning.

New Features:

  • Add fb section for framebuffer logo rendering with image path and dimensions

Bug Fixes:

  • Adjust shift values to correctly position the GhostBSD logo image

Enhancements:

  • Restructure logo configuration by replacing graphic field with ascii.image subsection
  • Introduce requires_color and shift parameters under ascii subsection

Summary by Sourcery

Modernize gfx-glogo.lua by restructuring the ASCII logo configuration, introducing a framebuffer logo subsection, and correcting logo positioning.

New Features:

  • Add fb section for framebuffer logo with image path and dimensions

Bug Fixes:

  • Adjust shift values to correctly position the GhostBSD logo image

Enhancements:

  • Restructure logo configuration by replacing graphic field with ascii.image subsection and introducing requires_color and shift parameters under ascii

The gfx-glogo.lua file was outdated I did bring up to date.
@ericbsd ericbsd requested review from a team as code owners November 14, 2025 00:10
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's Guide

Modernize gfx-glogo.lua by refactoring the ASCII logo into its own subsection with color and shift parameters, introducing a framebuffer ('fb') section for the GhostBSD image, and correcting its positioning offsets.

Entity relationship diagram for logo configuration data structure changes

erDiagram
    LOGO {
        ascii AsciiSection
        fb FbSection
    }
    AsciiSection {
        image string[]
        requires_color bool
        shift struct
    }
    FbSection {
        image string
        width int
        shift struct
    }
    LOGO ||--|{ AsciiSection : contains
    LOGO ||--|{ FbSection : contains
Loading

Class diagram for updated logo configuration structure in gfx-glogo.lua

classDiagram
class Logo {
  ascii : AsciiSection
  fb : FbSection
}
class AsciiSection {
  image : string[]
  requires_color : bool
  shift_x : int
  shift_y : int
}
class FbSection {
  image : string
  width : int
  shift_x : int
  shift_y : int
}
Logo --> AsciiSection : contains
Logo --> FbSection : contains
Loading

File-Level Changes

Change Details Files
Restructure ASCII logo configuration
  • Replace top-level 'graphic' field with an 'ascii.image' subsection
  • Introduce 'requires_color' flag under ascii
  • Add 'shift' parameters under ascii
  • Nest ASCII lines under the new 'ascii.image' key
stand/lua/gfx-glogo.lua
Add framebuffer logo rendering section
  • Introduce an 'fb' subsection under logo
  • Specify 'image' path and 'width' for framebuffer logo
  • Define 'shift' values within the fb section
stand/lua/gfx-glogo.lua
Fix GhostBSD logo positioning
  • Adjust fb.shift values to x=2, y=-2 for correct placement
  • Remove deprecated 'image' and 'image_rl' fields in favor of fb.width
stand/lua/gfx-glogo.lua

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

Thank you for taking the time to contribute to FreeBSD!
There is an issue that needs to be fixed:

  • Missing Signed-off-by linesc8e9e8f

Please review CONTRIBUTING.md, then update and push your branch again.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit ba66877 into releng/15.0 Nov 14, 2025
9 checks passed
@ericbsd ericbsd deleted the gfx-glogo-update branch November 14, 2025 09:59
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants