Fix for issue #22974. Cast intermediate results to float before adding.#22994
Open
scutler-nv wants to merge 1 commit into
Open
Fix for issue #22974. Cast intermediate results to float before adding.#22994scutler-nv wants to merge 1 commit into
scutler-nv wants to merge 1 commit into
Conversation
…re adding and casting the result to the destination type. Avoids half+half operator ambiguity.
github-actions
Bot
added
Nvidia GPU
JohannesGaessler
approved these changes
May 13, 2026
ggerganov
approved these changes
May 13, 2026
ggerganov
added
the
merge ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix for issue 22974. Cast intermediate results to float before adding and casting the result to the destination type. Avoids half+half operator ambiguity.
Requirements
None. Claude was used to develop the change.