opencl : fix memory allocation size#12649
Merged
max-krasnyansky merged 1 commit intoggml-org:masterfrom Apr 1, 2025
Merged
Conversation
issue: CodeLinaro#17 (comment) This patch fixes the memory allocation size not exceeding the maximum size of the OpenCL device.
github-actions
Bot
added
the
ggml
Contributor
Author
Contributor
Author
|
@lhez is not responding to my request. @max-krasnyansky, Could you review this PR? |
max-krasnyansky
approved these changes
Apr 1, 2025
Member
max-krasnyansky
left a comment
max-krasnyansky
left a comment
There was a problem hiding this comment.
Yep. Looks good to me (i.e. better than the original version).
@lhez we should add some comments about how those A_q_*_bytes magic numbers were computed.
Contributor
|
Yeah, we need to add some comments. Did some calculation last night and I think I recalled the calculation. I think we should make the calculation more formal and print out limitations when allocation is limited. |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
issue: CodeLinaro#17 (comment) This patch fixes the memory allocation size not exceeding the maximum size of the OpenCL device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
CodeLinaro#17 (comment)
This patch fixes the memory allocation size
not exceeding the maximum size of the OpenCL device.