Skip to content

📝 CodeRabbit Chat: Implement requested code changes #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yash-pouranik merged 1 commit into from
May 17, 2026
+50 −11
Merged

📝 CodeRabbit Chat: Implement requested code changes #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 49 additions & 10 deletions apps/public-api/src/controllers/mail.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ module.exports.getMailStatus = async (req, res) => {
try {
const { resendId } = req.params;
if (!resendId) return res.status(400).json({ success: false, data: {}, message: "resendId is required." });
if (!/^[A-Za-z0-9_-]{1,128}$/.test(resendId)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid resendId format." });
}

const projectId = req.project?._id;
const logEntry = await MailLog.findOne({ resendEmailId: resendId, projectId }).lean();
Expand Down Expand Up @@ -612,8 +615,12 @@ module.exports.getAudiences = async (req, res) => {

module.exports.getAudienceById = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience ID format." });
}
const resend = await requireByokGate(req);
const { data, error } = await resend.audiences.get(req.params.id);
const { data, error } = await resend.audiences.get(id);
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand All @@ -624,8 +631,12 @@ module.exports.getAudienceById = async (req, res) => {

module.exports.deleteAudience = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience ID format." });
}
const resend = await requireByokGate(req);
const { data, error } = await resend.audiences.remove(req.params.id);
const { data, error } = await resend.audiences.remove(id);
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand All @@ -638,8 +649,11 @@ module.exports.deleteAudience = async (req, res) => {

module.exports.addContact = async (req, res) => {
try {
const resend = await requireByokGate(req);
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience ID format." });
}
const resend = await requireByokGate(req);
const { email, firstName, lastName, unsubscribed } = req.body;
if (!email) return res.status(400).json({ success: false, data: {}, message: "Contact email is required." });

Expand All @@ -659,8 +673,12 @@ module.exports.addContact = async (req, res) => {

module.exports.getContacts = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience ID format." });
}
const resend = await requireByokGate(req);
const { data, error } = await resend.contacts.list({ audienceId: req.params.id });
const { data, error } = await resend.contacts.list({ audienceId: id });
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand All @@ -671,8 +689,11 @@ module.exports.getContacts = async (req, res) => {

module.exports.getContactById = async (req, res) => {
try {
const resend = await requireByokGate(req);
const { id, contactId } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id) || !/^[A-Za-z0-9_-]+$/.test(contactId)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience or contact ID format." });
}
const resend = await requireByokGate(req);
const { data, error } = await resend.contacts.get({ audienceId: id, id: contactId });
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

Expand All @@ -684,8 +705,11 @@ module.exports.getContactById = async (req, res) => {

module.exports.updateContact = async (req, res) => {
try {
const resend = await requireByokGate(req);
const { id, contactId } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id) || !/^[A-Za-z0-9_-]+$/.test(contactId)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience or contact ID format." });
}
const resend = await requireByokGate(req);
const { firstName, lastName, unsubscribed } = req.body;

const payload = { audienceId: id, id: contactId };
Expand All @@ -704,8 +728,11 @@ module.exports.updateContact = async (req, res) => {

module.exports.deleteContact = async (req, res) => {
try {
const resend = await requireByokGate(req);
const { id, contactId } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id) || !/^[A-Za-z0-9_-]+$/.test(contactId)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid audience or contact ID format." });
}
const resend = await requireByokGate(req);
const { data, error } = await resend.contacts.remove({ audienceId: id, id: contactId });
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

Expand Down Expand Up @@ -755,8 +782,12 @@ module.exports.createBroadcast = async (req, res) => {

module.exports.sendBroadcast = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid broadcast ID format." });
}
const resend = await requireBroadcastGate(req);
const { data, error } = await resend.broadcasts.send(req.params.id);
const { data, error } = await resend.broadcasts.send(id);
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand All @@ -779,8 +810,12 @@ module.exports.getBroadcasts = async (req, res) => {

module.exports.getBroadcastById = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid broadcast ID format." });
}
const resend = await requireBroadcastGate(req);
const { data, error } = await resend.broadcasts.get(req.params.id);
const { data, error } = await resend.broadcasts.get(id);
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand All @@ -791,8 +826,12 @@ module.exports.getBroadcastById = async (req, res) => {

module.exports.deleteBroadcast = async (req, res) => {
try {
const { id } = req.params;
if (!/^[A-Za-z0-9_-]+$/.test(id)) {
return res.status(400).json({ success: false, data: {}, message: "Invalid broadcast ID format." });
}
const resend = await requireBroadcastGate(req);
const { data, error } = await resend.broadcasts.remove(req.params.id);
const { data, error } = await resend.broadcasts.remove(id);
if (error) return res.status(error.statusCode || 500).json({ success: false, data: {}, message: error.message });

return res.status(200).json({ success: true, data });
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/models/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ module.exports.Project = require('./Project');
module.exports.Log = require('./Log');
module.exports.PlatformEvent = require('./PlatformEvent');
module.exports.DeveloperActivity = require('./DeveloperActivity');
module.exports.MailLog = require('./MailLog');
module.exports.MailLog = require('./MailLog');