Add support for limiting the number of deltas generated#74
Draft
joebonrichie wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
By default deltas will be generated between every existing package to the latest relnum, this can use a huge amount of disk space, and, honestly, generating deltas for historical packages isn't entirely necessary.
Historically, the way this was avoided was to trim the repository packages down which also killed off old deltas. However, recently, we've been trying to keep historical packages in the repo for longer to allow for successful rollbacks as well as for debugging purposes if necessary.
*Summary
This PR add supports for only generating deltas for the last n packages
This allows us to strike a balance in production between providing useful deltas as well as not eating the huge disk space.
In actual production we'll probably pick a number between 2-3 assuming most users are reasonably up to date.