ferryd: Proactively remove stale deltas as new packages are indexed#73
Draft
joebonrichie wants to merge 1 commit into
Draft
ferryd: Proactively remove stale deltas as new packages are indexed#73joebonrichie wants to merge 1 commit into
joebonrichie wants to merge 1 commit into
Conversation
Previously, when packages were received any existing deltas packages would get silently dropped from the DB and effectively becoming on-disk orphans taking up huge amounts of disk space. Now, when we index a package in the repo, check if any deltas for that package exist and remove them proactively We have to do a small amount of additional dancing with the locking to avoid a deadlock when using AddLocalPackage() but otherwise, relatively straight-forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when packages were received any existing deltas packages would get silently dropped from the DB and effectively becoming on-disk orphans taking up huge amounts of disk space.
Now, when we index a package in the repo, check if any deltas for that package exist and remove them proactively
We have to do a small amount of additional dancing with the locking to avoid a deadlock when using AddLocalPackage() but otherwise, relatively straight-forward.