fix: Prevent script injection in release workflow#669
Open
fix-it-felix-sentry[bot] wants to merge 1 commit into
Open
fix: Prevent script injection in release workflow#669fix-it-felix-sentry[bot] wants to merge 1 commit into
fix-it-felix-sentry[bot] wants to merge 1 commit into
Conversation
Use environment variables instead of direct GitHub context interpolation in run scripts to prevent potential code injection attacks. Fixes: https://linear.app/getsentry/issue/VULN-1609 Fixes: https://linear.app/getsentry/issue/PRO-40 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security vulnerability in the GitHub Actions workflow where GitHub context data was directly interpolated in run scripts, which could allow code injection attacks.
Changes
env:blocks to steps inrelease-ghcr-version-tag.yaml${{ github.ref_name }}and${{ github.sha }}interpolation with environment variables$REF_NAMEand$GITHUB_SHASecurity Impact
This fix prevents potential script injection attacks by ensuring GitHub context values are passed through controlled environment variables rather than directly interpolated into shell commands.
References