feat: change DebugSession::source_by_path() to return SourceCode enum#758
Merged
feat: change DebugSession::source_by_path() to return SourceCode enum#758
DebugSession::source_by_path() to return SourceCode enum#758Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 73.90% 74.19% +0.28%
==========================================
Files 69 70 +1
Lines 14952 15112 +160
==========================================
+ Hits 11051 11213 +162
+ Misses 3901 3899 -2 |
vaind
changed the title
SourceCode enumDebugSession::source_by_path() to return SourceCode enum
loewenheim
requested changes
Feb 10, 2023
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Thanks for doing this!
vaind
force-pushed
the
feat/ppdb-sourcelink
branch
from
61ea71c to
524ebfd
Compare
loewenheim
approved these changes
Feb 13, 2023
vaind
commented
Feb 13, 2023
Swatinem
reviewed
Feb 13, 2023
| let mut source_link_mappings = Vec::new(); | ||
| for cdi in CustomDebugInformationIterator::new(&result, SOURCE_LINK_KIND)? { | ||
| let cdi = cdi?; | ||
| // Note: only handle module #1 (do we actually handle multiple modules in any way??) |
Contributor
There was a problem hiding this comment.
I believe there is only ever one module as defined in the specification.
Swatinem
reviewed
Feb 14, 2023
Merged
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Contributor
|
Don't take this as blocking the merge but I think it might be sensible to think about this a bit more. These thoughts came to mind:
This to me implied there are multiple ways to refer to source, some of which might exist concurrencly. I wonder if it makes sense to revisit this abstraction. If we do decide that the return value is an enum and you gotta deal with it there, then we should make this |
vaind
force-pushed
the
feat/ppdb-sourcelink
branch
from
cf65c78 to
647df89
Compare
Contributor
Author
|
Thanks @mitsuhiko, I've added the attribute. |
vaind
force-pushed
the
feat/ppdb-sourcelink
branch
from
647df89 to
1bde15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #735 - this changes
DebugSession::source_by_path()to return one of two options, a real source code, or an http source link.This is a breaking change so will require a new major version.