Skip to content

feat(k8s): allow container name overriding in PipelineStep#254

Open
fpacifici wants to merge 1 commit intomainfrom
fpacifici/override_container
Open

feat(k8s): allow container name overriding in PipelineStep#254
fpacifici wants to merge 1 commit intomainfrom
fpacifici/override_container

Conversation

@fpacifici
Copy link
Collaborator

Summary

  • Adds an optional container_name field to PipelineStepContext (defaults to pipeline-consumer)
  • Threads the value through parse_context(), build_container(), and PipelineStep.run()
  • Closes STREAM-813

Test plan

  • test_build_container_custom_name — verifies build_container() uses the provided name
  • test_run_custom_container_name — verifies the full PipelineStep.run() flow respects container_name
  • All 22 existing tests still pass

🤖 Generated with Claude Code

Adds an optional `container_name` field to `PipelineStepContext` that
lets callers override the default `pipeline-consumer` container name
in generated Kubernetes deployments.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@fpacifici fpacifici requested a review from a team as a code owner March 13, 2026 00:30
@linear-code
Copy link

linear-code bot commented Mar 13, 2026

@github-actions
Copy link

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (k8s) Allow container name overriding in PipelineStep by fpacifici in #254

Internal Changes 🔧

Deps

  • Bump virtualenv from 20.31.2 to 20.36.1 in /sentry_streams by dependabot in #248
  • Bump bytes from 1.10.1 to 1.11.1 in /sentry_streams by dependabot in #242
  • Bump urllib3 from 2.5.0 to 2.6.3 in /sentry_streams by dependabot in #239
  • Bump protobuf from 5.29.5 to 5.29.6 in /sentry_streams by dependabot in #244

🤖 This preview updates automatically when you update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants