Require sink at the end of a branch of the pipeline #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #218.
The rust adapter chains map and filter steps together in one step in rust.
This means that, when a map or filter is processed, it is not added to the
Rust consumer immediately. This only happens when the chain is finalized.
that happens when we encounter a step that cannot be chained or a sink.
Problem: if there is a sequence of map operations and no sink, these were
never added to the rust consumer.
This PR requires aa Sink to the end of each branch.
This idea depends on the assumption that, if you terminate a branch with
anything that can produce output, is likely wrong.
If a step can produce an output and it is at the end of the branch,
what should we do with those messages ?
Requiring a sink implies asking this question to the author of the
pipeline and letting them decide.