Skip to content

Conversation

@fpacifici
Copy link
Collaborator

All steps that allow for the settings to be overridden provide
an override_config method.

It seems the GCSSink did not use this mechanism to override the
config.
Fixed to make it comply with the other steps

@fpacifici fpacifici requested a review from a team as a code owner January 23, 2026 01:05
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@github-actions
Copy link

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Move gcssink config override out of the adapter by fpacifici in #228

🤖 This preview updates automatically when you update the PR.

@fpacifici fpacifici merged commit 3ead333 into main Jan 23, 2026
22 checks passed
@fpacifici fpacifici deleted the fpacifici/fix_sink_config branch January 23, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants