Skip to content

feat: Let SCM platform support self-hosted GitLab#111061

Merged
jacquev6 merged 4 commits intomasterfrom
jacquev6/scm-platform/gitlab-self-hosted
Mar 23, 2026
Merged

feat: Let SCM platform support self-hosted GitLab#111061
jacquev6 merged 4 commits intomasterfrom
jacquev6/scm-platform/gitlab-self-hosted

Conversation

@jacquev6
Copy link
Copy Markdown
Collaborator

The SCM platform is now more tolerant to GitLab integrations' external_id format.

@jacquev6 jacquev6 requested a review from cmanallen March 19, 2026 09:24
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 19, 2026
Comment thread src/sentry/scm/private/providers/gitlab.py Outdated
assert external_id.startswith(prefix)
self._repo_id = external_id[len(prefix) :]
# External ID format is "{gitlab_url}:{repo_id}"
assert ":" in external_id
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should raise an appropriate SCM exception. Most likely a coded error since we'll want to serialize this across the RPC boundary.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Addressed in ed65f44.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/sentry/scm/private/providers/gitlab.py Outdated
@jacquev6 jacquev6 merged commit a0fceab into master Mar 23, 2026
64 checks passed
@jacquev6 jacquev6 deleted the jacquev6/scm-platform/gitlab-self-hosted branch March 23, 2026 16:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants