feat(seer): Expose defaultCodingAgent and defaultCodingAgentIntegrationId org fields#111051
feat(seer): Expose defaultCodingAgent and defaultCodingAgentIntegrationId org fields#111051
Conversation
github-actions
bot
added
the
Scope: Backend
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
any tests that need updating?
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ryan953
force-pushed
the
ryan953/feat-serialize-defaultCodingAgent
branch
from
4ad72cc to
38a46dd
Compare
ryan953
force-pushed
the
ryan953/feat-serialize-defaultCodingAgent
branch
from
38a46dd to
cf809a0
Compare
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
…ent fields Setting defaultCodingAgent or defaultCodingAgentIntegrationId to null would either save the literal string "None" (via str(None)) or raise a TypeError (via int(None)) on the first write, when a new OrganizationOption row is being created. Guard with a None check before type-casting, matching the existing update path which already assigns the value directly. Add tests for clearing both fields to null, and remove the incomplete useQuery/options declarations from the settings form that were missing their imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
…ganization An arbitrary integration ID could be stored without checking ownership. Add a validate_defaultCodingAgentIntegrationId method that uses integration_service (silo-safe RPC) to confirm the integration exists for the given org before saving. Null is still allowed to clear the setting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "defaultCodingAgent": obj.get_option( | ||
| "sentry:seer_default_coding_agent", | ||
| None, | ||
| ), |
There was a problem hiding this comment.
defaultCodingAgent default mismatches option default
Medium Severity
defaultCodingAgent is read with fallback None, but ORG_OPTIONS still treats its default as SEER_DEFAULT_CODING_AGENT_DEFAULT ("seer"). This inconsistency means unset orgs serialize as null, while the save-path default comparison assumes "seer", so first-time writes of "seer" are treated as unchanged and can skip audit tracking.
Additional Locations (1)
2 participants
Followup to #110548
Related to AIML-2604