feat(alerts): Add pure Detector/Workflow version of OrganizationCombinedRuleIndexEndpoint

[kcons]

Not quite happy with the import cycle issues, and concerned about performance especially in sorting and filtering cases.

Fixes ISWF-2189.

[linear-code]

ISWF-2189 Make OrganizationCombinedRuleIndexEndpoint fetch Detectors and Workflows

[sentry-warden]

Invalid dataset parameter causes uncaught ValueError

The code at line 424 converts user-provided dataset query parameters directly to Dataset enum objects with Dataset(d) without validation. If a user provides an invalid dataset value (e.g., ?dataset=invalid), Python's Enum constructor raises a ValueError which is uncaught, resulting in a 500 error instead of a proper 400 Bad Request response.

Verification

Verified by reading the Dataset enum definition in src/sentry/snuba/dataset.py which shows it's a standard Python Enum. Enum(value) raises ValueError for invalid values. Compared to legacy path at line 655 which uses raw strings without enum conversion. The datasets variable comes directly from request.GET.getlist('dataset', []) at line 587 with no validation.

Also found at 1 additional location

• src/sentry/incidents/endpoints/organization_alert_rule_index.py:600-600

Identified by Warden sentry-backend-bugs · UJP-SDW

[github-actions]

Backend Test Failures

Failures on dbbaadd in this run:

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py::AlertRuleDetailsGetEndpointTest::test_workflow_engine_serializer — log

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:321: in test_workflow_engine_serializer
    assert resp.data["id"] == str(self.alert_rule.id)
E   TypeError: 'NoneType' object is not subscriptable

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py::AlertRuleDetailsGetEndpointTest::test_non_dual_written_detector_serialization — log

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:940: in test_non_dual_written_detector_serialization
    assert resp.data["id"] == str(fake_id)
E   TypeError: 'NoneType' object is not subscriptable

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py::AlertRuleDetailsGetEndpointTest::test_workflow_engine_serializer_anomaly_detection — log

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:450: in test_workflow_engine_serializer_anomaly_detection
    assert new_data["status"] == AlertRuleStatus.PENDING.value
E   TypeError: 'NoneType' object is not subscriptable

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py::AlertRuleDetailsGetEndpointTest::test_workflow_engine_serializer_matches_old_serializer — log

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:342: in test_workflow_engine_serializer_matches_old_serializer
    self.assert_alert_detail_results_match(old_data, new_data)
tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:240: in assert_alert_detail_results_match
    if field not in new_data:
E   TypeError: argument of type 'NoneType' is not iterable

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py::AlertRuleDetailsGetEndpointTest::test_workflow_engine_serializer_snoozed_alert_rule — log

tests/sentry/incidents/endpoints/test_organization_alert_rule_details.py:377: in test_workflow_engine_serializer_snoozed_alert_rule
    assert new_data["snooze"] is True
E   TypeError: 'NoneType' object is not subscriptable