feat(workflow-engine): Add TypedDicts for WorkflowValidator input format#110692
Open
feat(workflow-engine): Add TypedDicts for WorkflowValidator input format#110692
Conversation
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
Mar 13, 2026
Contributor
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
🫶 - love the addition of types and stricter checking than before.
| "name": data.get("name"), | ||
| ) -> WorkflowInput: | ||
| workflow_payload: WorkflowInput = { | ||
| "name": data.get("name", ""), |
Contributor
There was a problem hiding this comment.
we might want to have the name error if it's an empty string. i believe there's a unique constraint on the names, so it could get a little 😵
| triggers: dict[str, Any] = {"logicType": "any-short", "conditions": []} | ||
| translated_filter_list = [] | ||
| triggers: DataConditionGroupInput = {"logicType": "any-short", "conditions": []} | ||
| translated_filter_list: list[DataConditionInput] = [] |
Contributor
There was a problem hiding this comment.
🤔 should we have an DetectorTrigger, ActionFilterInput, WorkflowTriggerInput as detailed types? that way we can enforce stuff like a detectors conditions always must return a valid PriorityLevel? (not sure if there are other things we could enforce more strictly down, i feel like those might be helpful for folks making custom validators like the metric alert validator)
ceorourke
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to lean on mypy a bit more for correctness.