fix(explore): disable drop transition on group-by sortable items#110676
Open
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Open
fix(explore): disable drop transition on group-by sortable items#110676JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Same animation glitch as the metrics toolbar — the dnd-kit drop transition conflicts with the state update that reorders the DOM. Matches the pattern already used in SortableVisualizeFieldWrapper and SortableQueryField. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the dnd-kit drop transition on group-by sortable items in the explore toolbar to fix a visual animation glitch when reordering.
The state update on drop already handles visual reordering instantly. The dnd-kit drop transition conflicts with this, causing items to briefly animate from a stale position. Setting
transition: nullinuseSortablematches the pattern already used inSortableVisualizeFieldWrapperandSortableQueryField.I'd noticed & fixed this same kind of bug when QAing #110648. Example place where this one pops up: Explore > Traces.
Screen.Recording.2026-03-13.at.3.57.00.PM.mov
Fixes EXP-842.
Made with Cursor