Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/issues/endpoints/group_tagkey_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from sentry.api.api_publish_status import ApiPublishStatus
from sentry.api.base import region_silo_endpoint
from sentry.api.exceptions import ResourceDoesNotExist
from sentry.api.helpers.deprecation import deprecated
from sentry.api.helpers.environments import get_environments
from sentry.api.serializers import serialize
from sentry.api.serializers.models.tagvalue import UserTagValueSerializer
Expand All @@ -20,6 +21,7 @@
from sentry.apidocs.examples.tags_examples import TagsExamples
from sentry.apidocs.parameters import GlobalParams, IssueParams
from sentry.apidocs.utils import inline_sentry_response_serializer
from sentry.constants import CELL_API_DEPRECATION_DATE
from sentry.issues.endpoints.bases.group import GroupEndpoint
from sentry.ratelimits.config import RateLimitConfig
from sentry.tagstore.types import TagValueSerializerResponse
Expand Down Expand Up @@ -67,6 +69,7 @@ class GroupTagKeyValuesEndpoint(GroupEndpoint):
},
examples=[TagsExamples.GROUP_TAGKEY_VALUES],
)
@deprecated(CELL_API_DEPRECATION_DATE, url_names=["sentry-api-0-group-tag-key-values"])
def get(self, request: Request, group, key) -> Response:
"""
List a Tag's Values
Expand Down
20 changes: 9 additions & 11 deletions tests/sentry/issues/endpoints/test_group_tagkey_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_simple(self, mock_record: mock.MagicMock) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/{key}/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/{key}/values/"

response = self.client.get(url)

Expand Down Expand Up @@ -55,7 +55,7 @@ def test_simple_perf(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{event.group.id}/tags/{key}/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{event.group.id}/tags/{key}/values/"

response = self.client.get(url)

Expand Down Expand Up @@ -84,7 +84,7 @@ def test_user_tag(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/user/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/user/values/"

response = self.client.get(url)

Expand Down Expand Up @@ -116,9 +116,7 @@ def test_tag_value_with_backslash(self) -> None:

self.login_as(user=self.user)

url = (
f"/api/0/issues/{group.id}/tags/message/values/?query=minidumpC%3A%5C%5CUsers%5C%5Ctest"
)
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/message/values/?query=minidumpC%3A%5C%5CUsers%5C%5Ctest"

response = self.client.get(url)

Expand Down Expand Up @@ -149,7 +147,7 @@ def test_includes_empty_values_by_default(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/foo/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/foo/values/"

response = self.client.get(url)

Expand Down Expand Up @@ -183,7 +181,7 @@ def test_includes_empty_values_backend_helpers(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/foo/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/foo/values/"

group_tag_key = tagstore.backend.get_group_tag_key(
group,
Expand Down Expand Up @@ -235,7 +233,7 @@ def test_user_tag_with_empty_values(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/user/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/user/values/"

# This should not crash with AttributeError: 'NoneType' object has no attribute 'split'
response = self.client.get(url)
Expand Down Expand Up @@ -294,7 +292,7 @@ def test_count_sort(self) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/user/values/?sort=count"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/user/values/?sort=count"

response = self.client.get(url)

Expand Down Expand Up @@ -322,7 +320,7 @@ def test_ratelimit(self, mock_record: mock.MagicMock) -> None:

self.login_as(user=self.user)

url = f"/api/0/issues/{group.id}/tags/{key}/values/"
url = f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/tags/{key}/values/"

with freeze_time(datetime.datetime.now()):
for i in range(150):
Expand Down
Loading