fix(preprod): filter insight diff tabs by status #106900
Open
+116
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure unresolved/resolved tabs only show matching diff rows and recompute potential savings from the filtered items.
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/views/preprod/buildComparison/main/insightComparisonSection.tsx
Outdated
Show resolved
Hide resolved
mtopo27
force-pushed
the
mtopo27/filter-insight-diff-tabs
branch
from
8c839c8 to
55ae8dd
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ); | ||
| if (resolvedInsight) { | ||
| byTab.resolved.push(resolvedInsight); | ||
| } |
Contributor
There was a problem hiding this comment.
Missing status check for resolved tab filtering
Medium Severity
The resolved tab filtering lacks a status === 'resolved' check, unlike the unresolved and new tabs which both check the insight's status before including it. This causes any insight (regardless of status) that has removed or decreased diff items to appear in the resolved tab. An insight with status: 'unresolved' could appear in both the unresolved and resolved tabs if it has mixed diff types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: the insight tabs show the # of insight cards, where within the cards, its the number of insight items, so there's a mismatch between tabs and what is on the UI. That existed already, not going to touch in this PR
prod
Prod
PR (filtered for unresolved)
PR (filter for resolved)
