Skip to content

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Jan 23, 2026

@ryan953 ryan953 requested review from a team as code owners January 23, 2026 18:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 23, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

}),
]
: [''],
: ([''] as ApiQueryKey),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing email query parameter in member lookup

High Severity

The useMemberLookup hook's email lookup is missing the query filter parameter. The original code included {query: {query: \email:${email}`}}to filter members by email, but this was accidentally omitted during the refactor. The name lookup (lines 486-494) correctly preserves its query parameter{query: {query: name}}, but the email lookup now fetches all organization members unfiltered. This causes memberDataByEmail?.[0]` to return an arbitrary member rather than the one matching the specified email, breaking triage assignee matching functionality.

Fix in Cursor Fix in Web

const result = await fetchDataQuery<SyncReposResponse>(context);
const result = await fetchDataQuery<SyncReposResponse>(
context as unknown as QueryFunctionContext<ApiQueryKey, unknown>
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache invalidation uses mismatched query key format

Medium Severity

The cache invalidation in useSyncRepos still uses a raw string template literal for the repositories query key, but useInfiniteRepositories was updated to use getApiUrl() for its query key. This mismatch means queryClient.invalidateQueries() won't find the cached query because the keys are constructed differently. After a successful repository sync, the stale repository list won't be refreshed because the invalidation silently fails to match.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants