ref: Use getApiURl() inside of static/gsApp/*
#106893
Open
+233
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| { | ||
| path: {organizationIdOrSlug: organization.slug, projectIdOrSlug: project?.id!}, | ||
| } | ||
| ), |
Contributor
There was a problem hiding this comment.
Wrong project identifier used in spikesList API call
High Severity
The spikesList API call was refactored from using project?.slug to project?.id!. The original code used the project's slug (/spikes/projects/${project?.slug}/), but the new code passes project?.id! as the projectIdOrSlug parameter. This changes the actual API endpoint being called, which will likely cause the request to fail or return incorrect data. The adjacent spikeThresholds query correctly uses project?.slug!, making this inconsistency apparent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://gist.github.com/ryan953/af5458fa4f89ae42cc19e8ea266b7e9a