-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(relocation) Extend timeouts for relocation #106881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Sales is trying to move a larger customer account and hitting timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| DEFAULT_VALIDATION_TIMEOUT = timedelta(minutes=60) | ||
| CROSS_REGION_EXPORT_TIMEOUT = timedelta(minutes=60) | ||
| DEFAULT_VALIDATION_TIMEOUT = timedelta(minutes=80) | ||
| CROSS_REGION_EXPORT_TIMEOUT = timedelta(minutes=80) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polling limit inconsistent with extended validation timeout
High Severity
The DEFAULT_VALIDATION_TIMEOUT was increased from 60 to 80 minutes, but MAX_VALIDATION_POLLS remains at 60. Since each poll runs with a 60-second countdown and polls are limited to MAX_VALIDATION_POLL_ATTEMPTS (61), the system can only poll for approximately 61 minutes. If CloudBuild takes between 61-80 minutes (which the extended timeout now allows), the relocation will fail prematurely due to exhausted poll attempts, defeating the purpose of extending the timeout.
Sales is trying to move a larger customer account and hitting timeouts.